Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s#grpc#@grpc/grpc-js# #483

Merged
merged 1 commit into from
Apr 21, 2021
Merged

s#grpc#@grpc/grpc-js# #483

merged 1 commit into from
Apr 21, 2021

Conversation

lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Apr 21, 2021 •
edited
Loading

As per open-telemetry/opentelemetry-js#2130 this should work...

@lizthegrey lizthegrey requested a review from ayust April 21, 2021 17:01
@lizthegrey lizthegrey merged commit df53e07 into master Apr 21, 2021
@lizthegrey lizthegrey deleted the lizf.grpc-js branch April 21, 2021 21:41
@lizthegrey
Copy link
Member Author

despite CI passing, this fails:

       > eve-roster@1.0.0 start /app
       > node out/server/bin/witness/witness.js
       [witness] Spawning child "/app/out/server/server.js"...
       [witness] Base logs path: /logs
       [witness] Opening log file /logs/roster_logs_2021-04-22.txt
       2021-04-22T00:43:30.299Z   189 E [server] Unhandled promise rejection
       2021-04-22T00:43:30.340Z   189 E TypeError: Channel's second argument (credentials) must be a ChannelCredentials
       2021-04-22T00:43:30.341Z   189 E     at ServiceClient.Client (/app/node_modules/grpc/src/client.js:460:23)
       2021-04-22T00:43:30.341Z   189 E     at new ServiceClient (/app/node_modules/grpc/src/client.js:986:12)
       2021-04-22T00:43:30.341Z   189 E     at /app/node_modules/@opentelemetry/exporter-collector-grpc/src/util.ts:54:35
       2021-04-22T00:43:31.353Z   189 I [server] Serving from port 5000.

need to grab soon to be cut v0.19 or a git hash of otel-js to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayust ayust Awaiting requested review from ayust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lizthegrey